Feat/docs#109
Open
giuliana-gladeye wants to merge 34 commits into
Open
Conversation
Collaborator
Author
|
Note that
|
Shrinks99
reviewed
Jul 14, 2026
| `packages/ui/src/components/spinner/spinner.tsx` | ||
| - **Loading Overlay** — no `role="status"`/`aria-live`, no focus trap, and no `aria-busy` on the blocked content. Screen reader users may not be told loading started, and keyboard focus can still reach content behind the overlay. Add a live region and focus management. | ||
| `packages/ui/src/components/loading-overlay/loading-overlay.tsx` | ||
| - **Command** — keyboard navigation works, but there is no visual highlight for the active item. cmdk marks it with `data-selected="true"`, but `.command-item` only styles `:hover`/`:focus`. Add a `data-[selected=true]` rule mirroring the hover colors: |
Member
There was a problem hiding this comment.
Visual highlight Looks fine to me on in-app nav search, selects as expected but may need to check how the tab order works on the command component itself?
| `packages/ui/src/components/command/command.module.css` | ||
| - **Pagination** — numbered page buttons convey the current page only via color (`primary` vs `tertiary`), with no `aria-current="page"`; the control group isn't wrapped in a `<nav aria-label="Pagination">` landmark. | ||
| `packages/ui/src/components/pagination/pagination.tsx` | ||
| - **Icon Button** — `label` (which becomes `aria-label`) is optional, but an icon-only button with no label is unlabeled for screen readers. Consider making `label` required. |
Member
There was a problem hiding this comment.
Optional to prevent double labels when used with tooltips
| `packages/ui/src/components/pagination/pagination.tsx` | ||
| - **Icon Button** — `label` (which becomes `aria-label`) is optional, but an icon-only button with no label is unlabeled for screen readers. Consider making `label` required. | ||
| `packages/ui/src/components/icon-button/icon-button.tsx` | ||
| - **Copy Button** — on success the label swaps to "Copied!" but there's no `aria-live` region, so the confirmation isn't announced. Add a visually-hidden live region. |
Member
There was a problem hiding this comment.
Add tooltip that appears on copy that says "Copied!"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create-documentationskill.tableFUTURE_IMPROVEMENTS.md, a list of component improvements surfaced while writing documentation.Drawerfrom docs only since component is unfinished. See note inFUTURE_IMPROVEMENTS.md.