-
Notifications
You must be signed in to change notification settings - Fork 18
Making the module compileable with Debian 13 #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Very late to the party but I've been using this PR in my Rocky 9 EPICS builds and it works well. |
|
We have removed module support from EPICS-env v1.1.2. It is now available in the legacy support repository: https://github.com/jeonghanlee/EPICS-legacy-support I am closing this pull request and will continue the work on my fork until this module support is officially phased out. |
|
@tynanford I re-opened it. |
Update CI for debian 11-13
|
I believe this is ready to merge. The changes make pyDevSup compatible with numpy v1 and v2. Also compatible with newer versions of python. The ci scripts submodule was updated to the latest commit and the CI jobs were expanded to test python 3.6 - 3.13 |
|
@pheest I see you already found and fixed the removal of If that solution works for numpy 1 and 2 then that looks better than what I did. Also your windows PR #33 and this PR are crossing paths a bit. Any thoughts on how best to go about this? My proposal would be to split the task of fixing python/numpy support from the task of adding windows support but curious what you think |
|
I can confirm I have it working and tested for Python versions 3.6 (numpy==1.19.5) to 3.13 (numpy==2.3.3). We should probably have a chat about this; I will send you a mail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Debian 13, and found a few issues regarding the explicit type casting in dbfield.c, please see the patch attached:
0001-FIX-Cast-to-PyArrayObject-warning-of-comparsion-inte.patch
The ci scripts might also needs to be updated, Debian 13 is using gcc 14.
|
I tried to push my commits with a new branch to this repo, but failed, see #42, I'm not sure how to fix it. |
|
Thanks @zhangt58 ! I've created a PR on your branch since that will be easier to work with. Closing this PR |
@mdavidsaver @tynanford
As you know, I don't know the Python and I hate the Python. Somehow, our environment still needs it, so I would like to at least fix these compatibility issues and compile errors.
Please understand that this is my naive attempt to fix the following problems:
Issue: #35
The current PR contains the exact same code which Tynan proposed.
Issue: #37 and PR : #39
The current PR contains my proposal code with a code proposal from PR 39.
Debian 13 GCC compiling error
After the error, I looked through PyMethodDef examples >= Python Version 3 at https://docs.python.org/3.12/extending/extending.html#compilation-and-linkage
Then, I suspect that the original code was not correct. Am I right?
I followed all examples from Python documentation from 3 to 3.12. Then I can compile the code with
gcc (Debian 14.2.0-3) 14.2.0. Is this something, the previous gcc cannot find? Or do I something wrong here?I need your testing and feedback so we can fix these problems together.