ci: add self-hosted CI workflow and raise test coverage - #2
Merged
Conversation
Add .github/workflows/ci.yml targeting the ephpm orgs
…inker) The ephemerd runner image ships without a C compiler. Even though switchboard is pure Rust, unavoidable transitive deps have build scripts (proc-macro2, libc) or compile C (ring, via reqwest's rustls stack), so every compile job died at "linker cc not found" before checking any of our code. fmt was unaffected (it never compiles). Add the same root/sudo-aware build-essential install step ephpm/ephpm uses to the clippy, test, and msrv jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds full CI for switchboard on the ephpm org's ephemerd self-hosted fleet, and raises unit-test coverage from 48 to 79 tests.
CI (
.github/workflows/ci.yml)Runs on
[self-hosted, linux, x64](same label ephpm/ephpm uses, so the fleet picks it up). Triggers: push tomain, PRs to[main, "feat/**"]. Jobs:cargo fmt --all -- --checkon stable (norustfmt.toml, so no nightly-only options; nightly is unnecessary here).cargo clippy --all-targets -- -D warnings.cargo test.cargo check --all-targetspinned to the declaredrust-version = 1.85.Pure Rust: no PHP, no SDK, no Docker.
Coverage (+31 tests)
Real behavior assertions over pure/testable logic only (no live-network or running-server tests):
app_idrejection.base64_url_encode— padding-free, URL-safe alphabet (-/_, never+//), decode round-trip.teardown_comment_body()fn so it's testable; added marker/table-structure, one-decimal duration rounding, and all-framework label coverage.preview_urlnon-8.x and arbitrary-8.x-minor edges, Symfony/Drupal detection + WordPress precedence, teardown removes the dir / is-ok-when-absent.database: none/ case-insensitive turso, explicit websocket, legacy-json default preservation.Local (WSL, shared warm target): fmt clean, clippy clean, 79/79 tests pass, MSRV 1.85 check passes.