-
Notifications
You must be signed in to change notification settings - Fork 31
Optimized differential privacy implementation #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tharvik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the great work! I added a few comments on how to improve parts of it but the core feature is there 🎉
btw, I don't remember if we talked about adding a test for the feature. for an integration test, you can add one in server/tests/e2e/federated.spec.ts trying out the feature and if you have some hardening/units tests in mind, you can also some in discojs/src/privacy.spec.ts to ensure that it works in many conditions.
136b2ce to
7fcc166
Compare
tharvik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated it a bit with the latest changes for byzantine impl, thanks for the huge contributions!
Gaussian noise calibration implementation
Adaptive clipping mechanism
cli testing tool modification
Webapp interface updates