EPMDEDP-17177: refactor: extract duplicated literals and hostname for matting in EventListener creation#293
Merged
Merged
Conversation
…matting in EventListener creation Extract duplicated string literals and event listener hostname formatting logic into constants and a helper function to reduce code duplication and improve maintainability. Addresses SonarQube code smell findings for the EventListener exposure code (Ingress, HTTPRoute, and Route variants). - Extract gitServer label string to gitServerLabel constant - Extract DNS wildcard error message to errGetDNSWildcard constant - Extract event listener hostname formatting to generateEventListenerHost() helper to centralize and prevent divergence across exposure methods Signed-off-by: Sergiy Kulanov <sergiy_kulanov@epam.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract duplicated string literals and event listener hostname formatting logic into constants and a helper function to reduce code duplication and improve maintainability. Addresses SonarQube code smell findings for the EventListener exposure code (Ingress, HTTPRoute, and Route variants).