Add input flag to skip bisection #1471
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked pending https://github.com/envoyproxy/nighthawk/pull/1472/changes
Core change adds
skip_bisectionflag to only check if we can add the latest Envoy commit and end.QoL tweaks:
git add .operation to end of Envoy commit integration - if the process makes it to that step, those changes are good and can be stored.latest_envoy_commitand replace with a check that the latest commit in the range is equal to the Nighthawk current Envoy commit andHEAD.latest_passing_commit_indexand incrementally updatebest_envoy_commitandfirst_non_trivial_commit