Skip to content

Conversation

@ebyerly
Copy link
Contributor

@ebyerly ebyerly commented Jan 6, 2026

Blocked pending https://github.com/envoyproxy/nighthawk/pull/1472/changes

Core change adds skip_bisection flag to only check if we can add the latest Envoy commit and end.

QoL tweaks:

  • Commit message includes Envoy commit date and a link to see the relevant Envoy commit.
  • move git add . operation to end of Envoy commit integration - if the process makes it to that step, those changes are good and can be stored.
  • remove extracting the Github username - Git UI already prints an equivalent message to stdout indicating the user can follow a link to create a pull request.
  • remove separate tracking of latest_envoy_commit and replace with a check that the latest commit in the range is equal to the Nighthawk current Envoy commit and HEAD.
  • remove separate tracking of latest_passing_commit_index and incrementally update best_envoy_commit and first_non_trivial_commit

@ebyerly ebyerly force-pushed the skip_bisection branch 2 times, most recently from 62849ed to 7fcddb2 Compare January 7, 2026 19:31
@ebyerly ebyerly added the waiting-for-review A PR waiting for a review. label Jan 7, 2026
@ebyerly ebyerly force-pushed the skip_bisection branch 3 times, most recently from 0b2e87a to 98c2f2c Compare January 8, 2026 14:12
@ebyerly ebyerly removed the waiting-for-review A PR waiting for a review. label Jan 8, 2026
Signed-off-by: Elizabeth Byerly <ebyerly@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant