fix(backfill): use baseRefName so deleted base branches don't null out base_ref#217
Open
anderdc wants to merge 1 commit into
Open
fix(backfill): use baseRefName so deleted base branches don't null out base_ref#217anderdc wants to merge 1 commit into
anderdc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The GraphQL PR backfill selects
baseRef { name }. In GitHub's schemabaseRefis a nullableRefthat resolves to null once the base branch is deleted or renamed away. Since the persist is an upsert keyed on (repoFullName, prNumber), the nightly backfill overwrites a previously-correct webhook-writtenbase_refwith null — pure data loss for the validator's branch-eligibility gate.Fix
Select
baseRefName(non-nullableString!) instead; it preserves the historical base ref name on the PR record even after branch deletion.baseRefOidandheadRefare untouched.Existing null rows self-repair whenever the incremental backfill next touches them.