Merged
Conversation
Replace the hand-rolled ~140-line bash release pipeline with GoReleaser v2, reducing the workflow to ~35 lines of YAML plus a ~65-line declarative .goreleaser.yml config. What GoReleaser now handles in a single command: - Cross-platform builds (linux/darwin/windows × amd64/arm64) - tar.gz / zip archiving - SHA256 checksums - Changelog generation from git log - GitHub Release creation with install instructions - Homebrew tap formula push to enthus-appdev/homebrew-tap This replaces the previous dawidd6/action-homebrew-bump-formula approach which failed due to two fundamental issues: 1. brew bump-formula-pr only updates the current platform's URL/SHA in multi-URL formulas (Homebrew/brew#8967 — not supported) 2. The generated bump-* branch name violated org-level branch naming rules GoReleaser avoids both: it generates the entire formula from scratch and pushes directly to the tap's main branch. Note: GoReleaser v2 deprecates `brews` in favor of `homebrew_casks`. Casks are the correct Homebrew format for precompiled binaries, but currently macOS-only — no Linux Homebrew support. Keeping `brews` for now to maintain cross-platform coverage. Revisit when the ecosystem evolves.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a .goreleaser.yml configuration file to automate the build and release process for the esq CLI tool across multiple platforms, including Homebrew support. A review comment suggests updating the deprecated brews key to homebrews to align with GoReleaser v2 standards.
GoReleaser v2 renamed brews → homebrews (the direct successor for CLI formula generation, supporting both macOS and Linux). The homebrew_casks key is a separate thing for macOS-only Casks — not what we need.
The previous commit changed brews → homebrews based on a review suggestion, but homebrews is not a valid GoReleaser v2 key (config validation fails). homebrew_casks exists but has a different config structure (no test/install blocks — it generates actual macOS Casks, not formulas). brews is the only key that works today. The deprecation warning is acknowledged — when GoReleaser provides a formula-compatible successor, we migrate then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hand-rolled bash release pipeline with GoReleaser v2. This is the pilot migration — once validated on a real release, the same pattern fans out to
atl-cliandn8n-cli.What changes
.goreleaser.ymldeclarative config (~65 lines)softprops/action-gh-releasefor release creationdawidd6/action-homebrew-bump-formulafor tap updatebrews:pushes formula directly to tapWhy GoReleaser
The previous approach (Option B —
dawidd6/action-homebrew-bump-formula) failed due to two fundamental issues discovered during the v1.1.1 pilot release:brew bump-formula-pr --version=only downloads and updates the SHA for the runner's own platform (linux-amd64). The other 3 platform URLs (darwin-arm64, darwin-amd64, linux-arm64) were left with stale SHAs — broken installs on 3 of 4 platforms.brew bump-formula-prcreatesbump-*branches which are rejected by the org-level branch naming ruleset.GoReleaser avoids both: it generates the entire formula from scratch and pushes directly to the tap's main branch (no bump branch, no PR).
Auth
Same GitHub App (
enthus-appdev-tap-bumper) and org secrets from before:HOMEBREW_TAP_APP_ID/HOMEBREW_TAP_APP_PRIVATE_KEYactions/create-github-app-token@v2and passed to GoReleaser asHOMEBREW_TAP_TOKENKnown deprecation
GoReleaser v2 flags
brewsas deprecated in favor ofhomebrew_casks(proper Homebrew Casks). However, Homebrew Casks are macOS-only — no Linux Homebrew support. Since our CLIs ship for both platforms, we keepbrewsfor now. This is explicitly called out in the config and will be revisited when the ecosystem evolves.Test plan
.goreleaser.ymlpassesgoreleaser checkrelease.ymlis valid YAMLv1.2.0(or next version)Formula/esq.rbtoenthus-appdev/homebrew-tapwith correct version + SHA256s for all 4 platformsbrew install enthus-appdev/tap/esqinstalls the new versionRollout
After validation, same
.goreleaser.yml+ simplifiedrelease.ymlpattern gets applied to:enthus-appdev/atl-cli(formula name:atl, entry:./cmd/atl, ldflags:main.version,main.commit,main.date)enthus-appdev/n8n-cli(formula name:n8nctl, entry:./cmd/n8nctl, ldflags:github.com/enthus-appdev/n8n-cli/internal/cmd.version)