Modernize IGlobalInterfaceTable with type hints.#941
Merged
Conversation
…ores. - Replace wildcard `ctypes` import with explicit `POINTER` import. - Remove unused `COMMETHOD` import. - Remove `comtypes/git.py` from `per-file-ignores` in `pyproject.toml`.
…omtypes/git.py`. The manual test code in the main block is no longer needed as the functionality is covered by other tests or was intended only for local verification.
Add `# type: ignore` to `RegisterInterfaceInGlobal`, `GetInterfaceFromGlobal`, and `RevokeInterfaceFromGlobal` in `IGlobalInterfaceTable` to suppress type checking errors for generated `__com_*` methods.
- Use `TypeVar` `_T_IUnknown` to define generic interface types. - Add type hints to `RegisterInterfaceInGlobal`, `GetInterfaceFromGlobal`, and `RevokeInterfaceFromGlobal`. - Update method signatures to use `_T_IUnknown` for improved type safety.
junkmd
added
typing
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #941 +/- ##
=======================================
Coverage 88.94% 88.94%
=======================================
Files 139 139
Lines 13649 13651 +2
=======================================
+ Hits 12140 12142 +2
Misses 1509 1509 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Introduced type hints to
IGlobalInterfaceTablemethods, performed code cleanup incomtypes/git.py, and resolved linter errors.These changes improve type safety for cross-apartment COM interface operations.