fix: make un_enerdata_demand_2050_final.csv an optional input - #59
Merged
Conversation
data/un_enerdata_demand_2050_final.csv is a manually-provided, gitignored file that was unconditionally required by prepare_regional_network, calculate_regional_lcox, and model_trade, even though it's only actually read on the 'reserved' supply-curve scenario (local demand reservation target) and the unused 'hydrogen' final-product branch of model_trade.py. With the current default scenario (allocated_share) and final_product (steel), the file was dead weight that still had to exist on disk for the DAG to build. Make the input conditional on when it's actually consumed, so runs using allocated_share/unreserved or the steel chain no longer need it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data/un_enerdata_demand_2050_final.csv is a manually-provided, gitignored file that was unconditionally required by prepare_regional_network, calculate_regional_lcox, and model_trade, even though it's only actually read on the 'reserved' supply-curve scenario (local demand reservation target) and the unused 'hydrogen' final-product branch of model_trade.py. With the current default scenario (allocated_share) and final_product (steel), the file was dead weight that still had to exist on disk for the DAG to build.
Make the input conditional on when it's actually consumed, so runs using allocated_share/unreserved or the steel chain no longer need it.