fixing breaking world bank country names and multiple small ones - #53
Merged
Conversation
Owner
|
@JanTautorus thank you for the small fixes. I have discarded the config changes and accepted the rest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running shift for a different set of regions and noticed a silent bug in prepare_wacc -> sometimes the current look up doesn't work and the wavv of the region is dropped. I only noticed this because there were some single country regions in my new mapping.
I also noticed that sometimes the solver stops but still writes down some unreasonable LCOE, which I guarded against by requiring an optimal solver status
Also included a speedup for the steel processing cost calculation.
@energyLS Please only integrate the file changes and discard the config changes