Repository navigation
Introduce backends as a module - #120
Merged
Merged
Conversation
cgl
force-pushed
the
refactor/package-backends
branch
from
October 23, 2026 15:51
41cbc9c to
67a1175
Compare
lovelydinosaur
requested changes
Oct 26, 2026
lovelydinosaur
left a comment
lovelydinosaur
left a comment
Member
There was a problem hiding this comment.
Looks like backends/__init__.py was committed by mistake.
| return raw_socket | ||
|
|
||
| monkeypatch.setattr("hip._network.socket.create_connection", create_connection) | ||
| monkeypatch.setattr("hip.backends.sync.socket.create_connection", create_connection) |
Member
There was a problem hiding this comment.
Another reminder to self...
- We probably want
backend.connect(host, port, secure)- mentioned in 🔪 How the interface oughta look to add our sync/async support. #99. - If we can avoid monkey patching, then let's.
lovelydinosaur
approved these changes
Oct 26, 2026
lovelydinosaur
left a comment
lovelydinosaur
left a comment
Member
There was a problem hiding this comment.
Yes. Good little change. Starts to get us towards...
- Documenting this currently internal-ish bit of API.
- Multiple backend implementations. (Eg. async support)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#116