Skip to content

respecting ordered sequence while partial update is fixed#9902

Open
Natgho wants to merge 20 commits intoencode:mainfrom
Natgho:6202-partial-update-respect-ordered-sequence
Open

respecting ordered sequence while partial update is fixed#9902
Natgho wants to merge 20 commits intoencode:mainfrom
Natgho:6202-partial-update-respect-ordered-sequence

Conversation

@Natgho
Copy link
Copy Markdown
Contributor

@Natgho Natgho commented Feb 25, 2026 •
edited
Loading

refs #6202

@Natgho Natgho mentioned this pull request Feb 25, 2026
Open
6 tasks
@Natgho
Copy link
Copy Markdown
Contributor Author

Natgho commented Feb 25, 2026

I considered including the ticket ID in the Description section of the test section, but decided it would be excessive. If you want it included, just let me know.

ProstoSerghei

This comment was marked as outdated.

Sign in to view

@Natgho Natgho requested a review from ProstoSerghei March 2, 2026 09:39
@auvipy auvipy requested review from auvipy and Copilot and removed request for ProstoSerghei March 2, 2026 10:07

This comment was marked as outdated.

Sign in to view

@Natgho Natgho requested a review from Copilot March 2, 2026 10:32

This comment was marked as outdated.

Sign in to view

@auvipy
Update tests/test_serializer_lists.py
1206cc4 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Natgho
Copy link
Copy Markdown
Contributor Author

Natgho commented Mar 2, 2026

The issues have been resolved and the PR looks ready. Is there anything else that needs improvement?

@auvipy auvipy requested a review from Copilot March 2, 2026 15:12
@auvipy
Copy link
Copy Markdown
Collaborator

auvipy commented Mar 2, 2026

lets wait for final rounds of reviews

This comment was marked as outdated.

Sign in to view

Natgho and others added 2 commits March 2, 2026 18:25
@Natgho
Update tests/test_fields.py
3bb0f16 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Natgho
comment is fixed for current solution explanation
12159c9
@Natgho Natgho requested a review from Copilot March 2, 2026 15:29

This comment was marked as outdated.

Sign in to view

@Natgho
Update tests/test_serializer_lists.py
1457bbc 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Natgho Natgho requested a review from Copilot March 2, 2026 15:37

This comment was marked as outdated.

Sign in to view

@Natgho Natgho requested a review from Copilot March 2, 2026 16:00

This comment was marked as outdated.

Sign in to view

@Natgho
Update rest_framework/fields.py
acf688b 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Natgho Natgho requested a review from Copilot March 2, 2026 16:06

This comment was marked as outdated.

Sign in to view

@Natgho Natgho requested a review from Copilot March 2, 2026 16:25
Copilot AI reviewed Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Natgho
Copy link
Copy Markdown
Contributor Author

Natgho commented Mar 2, 2026

Finally!
Sometimes I wish I had been born in the years before AI was created...

@Natgho
Copy link
Copy Markdown
Contributor Author

Natgho commented Mar 5, 2026

@auvipy what do you think?

@Natgho
Copy link
Copy Markdown
Contributor Author

Natgho commented Mar 27, 2026

@auvipy I would appreciate your feedback.

browniebroke
browniebroke requested changes Mar 27, 2026
View reviewed changes
@browniebroke
Copy link
Copy Markdown
Member

browniebroke commented Mar 27, 2026 •
edited
Loading

Also... What's up with all these added comments on code which basically unchanged? They are quite distracting... Did you write them or was it the work of an LLM?

@Natgho
Copy link
Copy Markdown
Contributor Author

Natgho commented Mar 27, 2026 •
edited
Loading

Also... What's up with all these added comments on code which basically unchanged? They are quite distracting... Did you write them or was it the work of an LLM?

I created the PR using AI, and I’m manually pushing AI for comment lines so I can track every action it takes in detail. If they seem intrusive or unnecessary, I can remove the comment lines.

browniebroke
browniebroke reviewed Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@browniebroke browniebroke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also... What's up with all these added comments on code which basically unchanged? They are quite distracting... Did you write them or was it the work of an LLM?

I created the PR using AI, and I’m manually pushing AI for comment lines so I can track every action it takes in detail. If they seem intrusive or unnecessary, I can remove the comment lines.

Ok that makes sense while you building it but I find the ratio of comments to code quite distracting, some are not providing a lot of value beyond duplicating what the code does.

PS: the rest of the PR looks good, and I don't mind making the final touches myself but I cannot push to your branch

@Natgho
Copy link
Copy Markdown
Contributor Author

Natgho commented Mar 29, 2026

Also... What's up with all these added comments on code which basically unchanged? They are quite distracting... Did you write them or was it the work of an LLM?

I created the PR using AI, and I’m manually pushing AI for comment lines so I can track every action it takes in detail. If they seem intrusive or unnecessary, I can remove the comment lines.

Ok that makes sense while you building it but I find the ratio of comments to code quite distracting, some are not providing a lot of value beyond duplicating what the code does.

PS: the rest of the PR looks good, and I don't mind making the final touches myself but I cannot push to your branch

Sorry for the late reply—I was moving to a different country and didn’t have access to my PC. I’ve added the final revisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@browniebroke browniebroke browniebroke requested changes

Copilot code review Copilot Copilot left review comments

@auvipy auvipy Awaiting requested review from auvipy

+1 more reviewer

@ProstoSerghei ProstoSerghei ProstoSerghei left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Natgho @auvipy @browniebroke @ProstoSerghei