Skip to content

Reject a trailing newline in SlugField #10075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohamed-alired wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reject a trailing newline in SlugField #10075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rest_framework/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ def __init__(self, allow_unicode=False, **kwargs):
if self.allow_unicode:
validator = RegexValidator(re.compile(r'^[-\w]+\Z', re.UNICODE), message=self.error_messages['invalid_unicode'])
else:
validator = RegexValidator(re.compile(r'^[-a-zA-Z0-9_]+$'), message=self.error_messages['invalid'])
validator = RegexValidator(re.compile(r'^[-a-zA-Z0-9_]+\Z'), message=self.error_messages['invalid'])
self.validators.append(validator)


Expand Down
8 changes: 8 additions & 0 deletions tests/test_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,6 +983,14 @@ class TestSlugField(FieldValues):
outputs = {}
field = serializers.SlugField()

def test_trailing_newline_is_invalid(self):
# `$` would also match before a trailing newline; Django's own slug
# validators reject it.
for allow_unicode in (False, True):
field = serializers.SlugField(allow_unicode=allow_unicode, trim_whitespace=False)
with pytest.raises(serializers.ValidationError):
field.run_validation('slug-99\n')

def test_allow_unicode_true(self):
field = serializers.SlugField(allow_unicode=True)

Expand Down
Loading