[windows] Always use Ninja generator when build cmake projects form source#1736
Draft
sbc100 wants to merge 2 commits into
Draft
[windows] Always use Ninja generator when build cmake projects form source#1736sbc100 wants to merge 2 commits into
sbc100 wants to merge 2 commits into
Conversation
sbc100
changed the title
sbc100
changed the title
sbc100
marked this pull request as draft
July 15, 2026 23:15
…ource When building tools from source, unconditionally use the Ninja generator. This massively simplifies the Windows build process allowing for the removal of `--vs2019`, `--vs2022`, `--mingw` and `--generator` flags along with `vswhere` detection, Visual Studio multi-config output paths, and the `mingw` SDK package. Instead we now rely on MSCV being configured in the environment prior to running emsdk. See: #1734
sbc100
changed the title
Update README.md to list `ninja` among required tools when building from source across platforms, and specify running inside a Visual Studio Developer Command Prompt on Windows. Also update the test comment in `test.py` regarding building from source on Windows. See: #1734
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building tools from source, unconditionally use the Ninja
generator.
This massively simplifies the Windows build process allowing for the
removal of
--vs2019,--vs2022,--mingwand--generatorflagsalong with
vswheredetection, Visual Studio multi-config output paths,and the
mingwSDK package.Instead we now rely on MSCV being configured in the environment prior
to running emsdk. i.e. We expect windows users to run in a Visual Studio
command prompt (or with
vcvarsall.bathaving been already run). Thisseems like a more sensible soltution that trying to build visual studio selection
into emsdk itself. i.e. we can just expect users to have already selected their
prefered visual studio version.
See: #1734