Split test_sockets.py into node and browser suites - #27555
Merged
Conversation
sbc100
approved these changes
Aug 17, 2026
sbc100
enabled auto-merge (squash)
August 17, 2026 19:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits the
socketstest suite intosockets_nodeandsockets_browser, as suggested by @sbc100 in #27207. A pure test refactor with no test content changes, so that the node socket tests no longer run under a browser-based suite.test/sockets_common.py: shared server harnesses and helpers (websockify/compiled harnesses, echo server processes, IPv6 loopback probe, skip decorators)test/test_sockets_node.py:sockets_node/sockets_node64onRunnerCore(previously these ran underBrowserCore) - the nodejs echo, connect-failure, subprotocol, and NODERAWSOCKETS teststest/test_sockets_browser.py:sockets_browser/sockets_browser64onBrowserCore- all btest-based tests, unchangedtest/runner.py, CircleCI config, and the test-suite docs updated; the chrome CI job now runs both suites, preserving existing coverageVerified that every test method in the old file appears exactly once across the new files.
Made with AI assistance under my review