Skip to content

Remove support for non-standard -no-pthreads command line flag #27546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbc100 wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −9
Open

Remove support for non-standard -no-pthreads command line flag #27546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15079,11 +15079,6 @@ def test_embind_optional_val_no_bind(self):
# was not included in the compilation unit using val.
self.do_runf('embind/test_optional_val_main.cpp', 'done\n', cflags=['-lembind', test_file('embind/test_optional_val_lib.cpp')])

def test_no_pthread(self):
self.do_runf_out_file('hello_world.c', cflags=['-pthread', '-no-pthread'])
self.assertExists('hello_world.js')
self.assertNotContained('new Worker(', read_file('hello_world.js'))

def test_sysroot_includes_first(self):
self.do_other_test('test_stdint_limits.c', cflags=['-iwithsysroot/include'])

Expand Down
4 changes: 0 additions & 4 deletions tools/cmdline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,10 +541,6 @@ def consume_arg_file():
settings.PTHREADS = 1
# Also set the legacy setting name, in case use JS code depends on it.
settings.USE_PTHREADS = 1
elif arg == '-no-pthread':
settings.PTHREADS = 0
# Also set the legacy setting name, in case use JS code depends on it.
settings.USE_PTHREADS = 0
elif arg == '-pthreads':
exit_with_error('unrecognized command-line option `-pthreads`; did you mean `-pthread`?')
elif arg == '-fno-rtti':
Expand Down
Loading