Separate test config from core compiler. NFC#27216
Open
sbc100 wants to merge 1 commit into
Open
Conversation
sbc100
force-pushed
the
test_config_split
branch
from
cb8965d to
0c91cd2
Compare
sbc100
force-pushed
the
test_config_split
branch
4 times, most recently
from
a1d3dde to
2add18f
Compare
sbc100
changed the title
sbc100
force-pushed
the
test_config_split
branch
2 times, most recently
from
1295a7e to
1788805
Compare
This is the first part of my plan to separate test setup from the compiler setup. Note that we no longer need `fix_js_engine` because we no longer do identity checks on the JS engine anywhere in the test code. i.e. we no longer depend on being able to do `if engine == V8_ENGINE`, and instead we have an `is_engine_v8` helper function.
sbc100
force-pushed
the
test_config_split
branch
from
1788805 to
46e02d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of my plan to separate test setup from the compiler setup.
Note that we no longer need
fix_js_enginebecause we no longer do identity checks on the JS engine anywhere in the test code. i.e. we no longer depend on being able to doif engine == V8_ENGINE, and instead we have anis_engine_v8helper function.See #27219 and #26453 for the long term reason for doing this, but its also just good hygiene to keep the test setup out of the core compiler.