Fix other.test_closure_webgpu_wasm64#26955
Merged
Merged
Conversation
This was broken by emscripten-core#26954 but not covered by CI because we run the `other` testsuite with the emsdk version of node that doesn't support wasm64.
Collaborator
Author
|
Landing TBR to fix the testsuite. |
tlively
reviewed
May 15, 2026
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
LGTM, but why is this necessary?
Collaborator
Author
|
See the PR description. The function is declared as returning a pointer-sized-thing, which means we wrap the return value in |
Member
|
Oh I see. "case" => "cast" in the description. |
Member
|
Oh, well I guess it's too late. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was broken by #26954 but not covered by CI because we run the
othertestsuite with the emsdk version of node that doesn't support wasm64.Without this change the wasm64 variant complains because it tried to case the return value of this function to a BigInt (pointer) before returning to Wasm.