Improve test_multiply_defined_libsymbols#26953
Merged
sbc100 merged 2 commits intoMay 14, 2026
Merged
Conversation
This test was first added in c735bb6.
sbc100
changed the title
kripken
approved these changes
May 14, 2026
| } | ||
| ''') | ||
|
|
||
| # Check linking libA.so multiple times (both directly and indirectly) does not result |
Member
There was a problem hiding this comment.
Suggested change
| # Check linking libA.so multiple times (both directly and indirectly) does not result | |
| # Check linking libA.so multiple times (both directly and indirectly) does not result in |
Co-authored-by: Alon Zakai <alonzakai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was first added in c735bb6. Hopefully these changes make it more obvious what is being tested, and also test more commonly used flags (
-sharedvs-r).Split out from #25930.