[Docs] adjust sphinx theme templates for gettext builder#26923
[Docs] adjust sphinx theme templates for gettext builder#26923hwhsu1231 wants to merge 1 commit into
Conversation
- Add `_()` and `{% trans %}{% endtrans %}` for gettext builder.
- Adjust the indentation of the sphinx theme templates.
- Trim trailing spaces and replace tabs with spaces.
|
Is this template something that we copied from an upstream location? If so, I'm not sure we want to be in the businesses of modifying it, unless it is an update from the upstream version, or some important fix? |
|
Hello @sbc100
Judging by the content, the entire emscripten_sphinx_rtd_theme appears to have been forked or copied from a specific version of sphinx_rtd_theme and subsequently customized.
The primary objective of this PR is to add |
|
I see, so is the idea that we could then followup with the translations themselves? i.e. does this change do anything on its own or does it require some actual translations too? Maybe you could submit just the translation stuff without the whitespace changes? Has the upstream |
|
Hello @sbc100
After this modification, we will be able to extract those wrapped strings by running
But the layout of the original Jinja templates is quite messy. I made these adjustments to make future maintenance easier.
Yes, it has, but there are some strings that are provided by the |
|
Perhaps we can just pull the latest version of the upstream theme once again, like @lorsanta did in the past. I'm wary of making downstream modifications to these files because we (I) don't really have any expertise in maintaining them over time, so its hard for is to know which modification and how to rebase them if/when we do want to pull in new upstream changed. Basically, I don't really understand this stuff, so I'm not very keen on carrying patches to it. But if folks like yourself and @lorsanta and interested in maintaining this stuff over time that seems reasonable and I think I should bow to your greater experience. |
_()and{% trans %}{% endtrans %}for gettext builder.