Simplify some pthreads tests. NFC#26905
Open
sbc100 wants to merge 1 commit into
Open
Conversation
Collaborator
sbc100
commented
May 9, 2026
sbc100
commented
- Convert tests from C++ to C where possible
- Remove the non-threaded code paths in tests that we always run threaded
sbc100
force-pushed
the
test_pthread_locale
branch
from
783c9ef to
0400ca2
Compare
sbc100
commented
May 12, 2026
Collaborator
Author
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Sorry some of the renames came with some reformatting so github doesn't should the rename.
I could split out the C++ -> C conversions to make the diff more readable if you prefer?
Member
Hmm, yeah, that would be nice if it's not too much trouble. |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 12, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 13, 2026
dschuff
approved these changes
May 13, 2026
|
|
||
| void *watch_count(void *t) | ||
| { | ||
| void *watch_count(void *t) { |
Member
There was a problem hiding this comment.
this new style doesn't match inc_count above.
sbc100
force-pushed
the
test_pthread_locale
branch
3 times, most recently
from
b3e2f5e to
456b867
Compare
- Convert tests from C++ to C where possible - Remove the non-threaded code paths in tests that we always run threaded
sbc100
force-pushed
the
test_pthread_locale
branch
from
456b867 to
f9ad581
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.