Skip to content

Add multithreaded variant of lua port #26886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrnickzh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add multithreaded variant of lua port #26886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9758e9e
Update lua.py
mrnickzh May 7, 2026
7a3b8b2
Update lua.py
mrnickzh May 7, 2026
a89ea08
Update test_other.py
mrnickzh May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2701,6 +2701,7 @@ def test_external_ports(self):
''', stdout)

@requires_network
@also_with_pthreads
def test_port_contrib_lua(self):
self.do_runf('other/test_port_contrib_lua.c', 'hello world\nHELLO WORLD\nsqrt(16)=4\n', cflags=['--use-port=contrib.lua'])

Expand Down
15 changes: 11 additions & 4 deletions tools/ports/contrib/lua.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@
LICENSE = 'MIT License'

port_name = 'contrib.lua'
lib_name = 'liblua.a'
variants = {'contrib.lua-mt': {'PTHREADS': 1}}

def get_lib_name(settings):
return 'liblua' + ('-mt' if settings.PTHREADS else '') + '.a'

def get(ports, settings, shared):
# get the port
Expand All @@ -36,10 +38,15 @@ def create(final):
ldblib.c liolib.c lmathlib.c loadlib.c loslib.c lstrlib.c ltablib.c lutf8lib.c linit.c
'''.split()

ports.build_port(source_path, final, port_name, srcs=srcs)
flags=[]

return [shared.cache.get_lib(lib_name, create, what='port')]
if settings.PTHREADS:
flags += ['-pthread']

ports.build_port(source_path, final, port_name, srcs=srcs, flags=flags)

return [shared.cache.get_lib(get_lib_name(settings), create, what='port')]


def clear(ports, settings, shared):
shared.cache.erase_lib(lib_name)
shared.cache.erase_lib(get_lib_name(settings))