Remove --proxy-to-worker/-sPROXY_TO_WORKER #25645
Merged
+35
−3,439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_proxy_to_worker
branch
from
bc1dbc0 to
8f5870e
Compare
sbc100
force-pushed
the
remove_proxy_to_worker
branch
4 times, most recently
from
4c306df to
af63385
Compare
sbc100
force-pushed
the
remove_proxy_to_worker
branch
3 times, most recently
from
407336c to
dc1f196
Compare
kripken
reviewed
Nov 19, 2025
kripken
reviewed
Nov 19, 2025
sbc100
force-pushed
the
remove_proxy_to_worker
branch
from
dc1f196 to
729685a
Compare
kripken
reviewed
Nov 20, 2025
kripken
approved these changes
Nov 20, 2025
Collaborator
Author
|
No worries, didn't mean to try to shame you! This is the first time I've following the my own new guidelines for feature deprecation/removal. I think it went pretty smoothly. I guess we will see if we get any reports form folks actually still using this. |
Collaborator
Author
sbc100
force-pushed
the
remove_proxy_to_worker
branch
from
729685a to
16542d7
Compare
juj
reviewed
Nov 20, 2025
juj
approved these changes
Nov 20, 2025
sbc100
force-pushed
the
remove_proxy_to_worker
branch
from
16542d7 to
a301168
Compare
kripken
reviewed
Nov 20, 2025
| - The `-sPROXY_TO_WORKER` setting (along with the corresponding | ||
| `--proxy-to-worker` flag) was removed due to lack of usage. If you were | ||
| depending on this feature but missed the PSA, please let us know about your | ||
| use case. (#25645, #25440) |
Member
There was a problem hiding this comment.
Suggested change
| use case. (#25645, #25440) | |
| use case. See also the PROXY_TO_PTHREAD and ENVIRONMENT=worker | |
| options, which might be useful replacements. (#25645, #25440) |
Collaborator
Author
There was a problem hiding this comment.
Maybe.. but they really are not direct replacements since you would need to do your own event proxying. Obviously we can keep adding more details to this changelog entry but really I think the github issues is the right place to go into more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty large, and complex feature that (as far as we can tell) had no users. See #25440 for more detail on the deprecation planning.
Fixes: #25440