fix: preserve GCC __attribute__ between enum keyword and name in AST#5
Closed
Copilot wants to merge 2 commits into
Closed
fix: preserve GCC __attribute__ between enum keyword and name in AST#5Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/emmtrix/cdt/sessions/5ce0a648-8caa-47b4-9c65-9ee8d83bb67b Co-authored-by: strimo378 <59825937+strimo378@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
strimo378
May 8, 2026 14:07
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__attribute__placed betweenenumand the tag name (e.g.enum __attribute__((packed)) color { ... }) was silently dropped from the AST. The parser consumed the tokens correctly but discarded the returned attribute list instead of attaching it to theIASTEnumerationSpecifier.Changes
AbstractGNUSourceCodeParser.enumSpecifier()— capture the return value of__attribute_decl_seq()and calladdAttributeSpecifiers(attributes, result)on the resulting enum specifier node, matching the pattern already used inclassSpecifier()forstruct/class/unionAST2Tests.testEnumAttribute()— regression test verifying thatenum __attribute__((packed)) color { ... }produces exactly one attribute specifier on the enum's decl specifier in the ASTChecklist: