Add inline and goto qualifier support to __asm__ declarations#3
Closed
Copilot wants to merge 3 commits into
Closed
Add inline and goto qualifier support to __asm__ declarations#3Copilot wants to merge 3 commits into
inline and goto qualifier support to __asm__ declarations#3Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/emmtrix/cdt/sessions/9c4b15e3-04dd-48a2-8514-3639dc110f3f Co-authored-by: strimo378 <59825937+strimo378@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
strimo378
May 6, 2026 08:22
View session
|
@copilot Fix run 25583771422 |
Agent-Logs-Url: https://github.com/emmtrix/cdt/sessions/9d1c2f7d-e2d4-4ee7-955f-16e05f4819ef Co-authored-by: strimo378 <59825937+strimo378@users.noreply.github.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC's
asm inlineandasm gotoqualifiers were silently rejected by CDT's parser. Additionally, the existingvolatilequalifier was consumed but never stored, making it inaccessible via the AST API.Description
Changes
IASTASMDeclaration— New API (@since 9.3):isVolatile()/setVolatile(),isInline()/setInline(),isGoto()/setGoto()CASTASMDeclaration/CPPASTASMDeclaration— Store all three qualifier flags; propagate throughcopy()AbstractGNUSourceCodeParser.asmDeclaration()— Parse qualifiers in a loop (any order, consistent with GCC); pass flags through tobuildASMDirective()DeclarationWriter— Emit qualifier keywords when rewriting ASM declarationsGCCCompleteParseExtensionsTest— New testtestAsmInlineGotoQualifierscovering all qualifiers individually and combined for both C and C++ parsersMETA-INF/MANIFEST.MF— BumpedBundle-Versionfrom9.3.200.qualifierto9.4.0.qualifierto reflect the new public API additionsChecklist: