fix: CodeTheme functions - ui and add builder #7684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/7684-fix-code-theme-functions View snapshot changes at kitdiff |
Its-Just-Nans
commented
Nov 5, 2025
Contributor
Author
|
Note that the potential other option is to remove the CodeTheme |
Contributor
Author
|
This MR also add methods to easily change the font and font size |
Its-Just-Nans
added a commit
to Its-Just-Nans/galago
that referenced
this pull request
Dec 13, 2025
emilk
approved these changes
Jan 5, 2026
| .lock_focus(true) | ||
| .desired_width(f32::INFINITY) | ||
| .layouter(&mut layouter); | ||
| let editor = if !cfg!(feature = "syntect") { |
Owner
There was a problem hiding this comment.
please swap the if/else branches to avoid the extra !
Contributor
Author
There was a problem hiding this comment.
Good idea, fixed
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this MR #7375
Without Syntect, the urrent theme selector is
global_theme_preference_buttons. It should be the dark_theme variable of the local CodeTheme - same as syntectTested with
cargo run # and cargo run --features syntectthanks for this amazing library!