Repository navigation
Conversation
Co-authored-by: embtom <16663460+embtom@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
embtom
October 6, 2026 06:57
View session
embtom
marked this pull request as ready for review
October 6, 2026 06:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark dashboard on gh-pages only plots each benchmark's history on its own chart. It doesn't put snprintf and ctprintf next to each other. This PR adds a side-by-side comparison generated from the same benchmark run.
scripts/benchmark-comparison.py(new)benchmark_snprintf_<case>withbenchmark_ctprintf_<case>.Nx fasterorNx slowerfor ctprintf).comparison.htmlwith paired bars, plus a markdown table.meanaggregate and ignores the other aggregates.benchmark_{snprintf,ctprintf}_<case>naming. Unpaired benchmarks are skipped..github/workflows/benchmark.yml$GITHUB_STEP_SUMMARY.comparison.htmlto the root ofgh-pages, next to the existing history dashboard. The page links back to that dashboard.github-action-benchmark, which also pushes togh-pages. The existingconcurrencygroup serializes runs, so I don't expect the two pushes to race.README.md: links to the comparison page.The benchmark sources and the existing dashboard are unchanged.
I only ran the script locally against a small hand-written results file. The workflow steps and the
gh-pagespublish haven't been exercised in CI yet.