improve batch rendering performance by moving VM blocks out of the DESTRYABLE_META - #21571
Open
NullVoxPopuli wants to merge 3 commits into
Open
improve batch rendering performance by moving VM blocks out of the DESTRYABLE_META#21571NullVoxPopuli wants to merge 3 commits into
NullVoxPopuli wants to merge 3 commits into
Conversation
NullVoxPopuli
force-pushed
the
nvp/perf/destroyable-slot-widen
branch
from
August 18, 2026 13:30
1396440 to
71a716e
Compare
Contributor
📊 Size reportTarball size — dist/dev 0.1%↑
dist/prod 0.1%↑
smoke-tests/v2-app-template/dist 0.1%↑
smoke-tests/v2-app-hello-world-template/dist 0.2%↑
🤖 This report was automatically generated by wyvox/pkg-size |
NullVoxPopuli
force-pushed
the
nvp/perf/destroyable-slot-widen
branch
from
August 18, 2026 15:01
194dffb to
b92b228
Compare
Contributor
Author
ef4
previously approved these changes
Aug 18, 2026
ef4
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


It's apparently faster to access a property on an object and do some checks, than it is to always ask a (weak)map for stuff
No downside.
@runspired knew about this perf optimization long ago: https://discord.com/channels/480462759797063690/1539315791088848936/1539319539295199242
so.. I'll be exploring where else we can do it in future PRs
This was explored with AI over here: #21569