Mixin migration - WIP#21429
Open
olenderhub wants to merge 6 commits into
Open
Conversation
Remove the legacy Comparable mixin (Mixin.create) and replace its only usage in compare() with a local isComparable function that checks whether compare is a function via duck-typing. - Delete packages/@ember/-internals/runtime/lib/mixins/comparable.ts - Delete comparable_test.js - Remove Comparable export from runtime/index.ts - Clean up stale references in lib/index.js, package.json, and tree-shakability test snapshots - Add regression test for non-function compare values
…r mixins - Delete obsolete @ember/enumerable stub package (index.ts, mutable.ts, package.json, and detect-only test) - Remove Enumerable import and extension from EmberArray - Remove MutableEnumerable import and extension from MutableArray - Remove MutableEnumerable re-export from @ember/-internals/runtime - Clean up Enumerable entries in root package.json, lib/index.js, tree-shakability test, and workspace package.json dependencies - Delete mutable_enumerable_test.js, which only tested MutableEnumerable.detect BREAKING CHANGE: @ember/enumerable and @ember/enumerable/mutable are removed. Legacy Enumerable.detect and MutableEnumerable.detect checks are no longer supported. Code that needs to detect Ember array behavior should use EmberArray.detect or MutableArray.detect where appropriate.
- Delete @ember/object/promise-proxy-mixin implementation - Remove promise-proxy-mixin package exports and entrypoints - Delete PromiseProxyMixin-specific runtime tests - Remove tracked-test case that depended on ArrayProxy.extend(PromiseProxyMixin) - Clean up docs expectations and tree-shakability entries BREAKING CHANGE: @ember/object/promise-proxy-mixin is removed. Code that used ObjectProxy.extend(PromiseProxyMixin) must migrate away from PromiseProxyMixin and manage promise state explicitly.
- Move TargetActionSupport#triggerAction directly onto Component - Move ActionSupport#send directly onto Component - Preserve triggerAction target/action/actionContext behavior and typings - Replace TargetActionSupport mixin tests with Component#triggerAction coverage - Remove ActionSupport and TargetActionSupport exports and entrypoints - Clean up tree-shakability expectations and stale mixin comments BREAKING CHANGE: private ActionSupport and TargetActionSupport mixin modules are removed. Component still provides send() and triggerAction() directly.
Inline proxy behavior directly into ObjectProxy. Move shared proxy tracking helpers into runtime/lib/proxy-utils: - ContentProxy - contentFor - customTagForProxy Remove the private _ProxyMixin runtime export and delete the old runtime/lib/mixins/-proxy module. Update internal imports, package entrypoints, and tree-shakability expectations accordingly. BREAKING CHANGE: private _ProxyMixin and runtime/lib/mixins/-proxy are removed. ObjectProxy still provides content forwarding, unknownProperty, setUnknownProperty, and isTruthy directly.
- Inline RegistryProxyMixin behavior directly into Engine and EngineInstance - Inline ContainerProxyMixin behavior directly into EngineInstance - Remove RegistryProxyMixin and ContainerProxyMixin runtime exports - Delete the old runtime/lib/mixins/registry_proxy and container_proxy modules - Update package entrypoints and tree-shakability expectations - Move container proxy behavior coverage from the deleted mixin test to EngineInstance BREAKING CHANGE: private RegistryProxyMixin and ContainerProxyMixin mixin modules are removed. Engine and EngineInstance still provide the same registry/container proxy APIs directly.
NullVoxPopuli
requested changes
May 26, 2026
Contributor
NullVoxPopuli
left a comment
NullVoxPopuli
left a comment
There was a problem hiding this comment.
thanks a ton for working on this! I see some things that can be extracted to separate PRs, and some things need to come back, but have deprecations added
Contributor
There was a problem hiding this comment.
we can't delete stuff yet -- it has to stick around until v8
| */ | ||
| without(value: T): NativeArray<T>; | ||
| } | ||
| const EmberArray = Mixin.create(Enumerable, { |
Contributor
There was a problem hiding this comment.
EmberArray is already deprecated (via RFC):
but we haven't shipped the EmberArray deprecation quite yet
Contributor
There was a problem hiding this comment.
so this means we can probably add deprecations to the whole thing, rather than deprecation the Enumerable methods on here
| interface Engine extends RegistryProxyMixin {} | ||
| class Engine extends Namespace.extend(RegistryProxyMixin) { | ||
| interface Engine extends RegistryProxy {} | ||
| class Engine extends Namespace { |
Contributor
There was a problem hiding this comment.
these are good changes -- whatever is in RegistryProxyMixin should probably be inlined in here (so as to not use a mixin) -- exactly what you've done 🎉
| class EngineInstance extends EmberObject.extend(RegistryProxyMixin, ContainerProxyMixin) { | ||
| // `EngineInstance` implements the registry/container proxy APIs directly. | ||
| interface EngineInstance extends InternalOwner, Owner {} | ||
| class EngineInstance extends EmberObject { |
Contributor
There was a problem hiding this comment.
these are good changes, and we could probably ship them in separate PRs -- any change that keeps the API the same, but removes a mixin is a good candidate for separate PR
Contributor
There was a problem hiding this comment.
can't remove this quite yet -- we could in v8 -- but we need to ship the deprecation first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP