Remove this.compile() usage from test files#21283
Open
NullVoxPopuli-ai-agent wants to merge 1 commit intoemberjs:mainfrom
Open
Remove this.compile() usage from test files#21283NullVoxPopuli-ai-agent wants to merge 1 commit intoemberjs:mainfrom
NullVoxPopuli-ai-agent wants to merge 1 commit intoemberjs:mainfrom
Conversation
NullVoxPopuli-ai-agent
force-pushed
the
nvp/replace-compile-with-runtime-template
branch
from
04c5ba3 to
2f00902
Compare
- life-cycle-test: use template() from @ember/template-compiler/runtime instead of this.compile() for setting component templates - template-factory-test: import compile directly from internal path (this test specifically tests TemplateFactory behavior) - multiple-app-test: import compile directly from internal path (registers route templates needing TemplateFactory) No test files call this.compile() anymore — it's now purely an internal implementation detail of the test case base classes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NullVoxPopuli-ai-agent
force-pushed
the
nvp/replace-compile-with-runtime-template
branch
from
2f00902 to
f644ede
Compare
Contributor
|
We can't fully get rid of compile until we get rid of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
this.compile()calls from test fileslife-cycle-test.js: usestemplate()from@ember/template-compiler/runtimeinsteadtemplate-factory-test.jsandmultiple-app-test.js: import compile directly from internal path (these need TemplateFactory)No test files call
this.compile()anymore — it's now purely an internal implementation detail of the test case base classes (used bythis.render()).Followup to #21281.
Test plan
🤖 Generated with Claude Code