v7 by NullVoxPopuli · Pull Request #21240 · emberjs/ember.js

NullVoxPopuli · 2026-03-24T21:04:19Z

Merges of:

Needs:

Support ember-source (ESM) -- without addon vendor paths ember-cli/ember-cli#10971
- Support ember-source (ESM) -- without addon vendor paths ember-cli/ember-cli#10972
Conditional file writes for Ember modules embroider-build/embroider#2695

github-actions · 2026-03-24T21:06:54Z

📊 Package size report `-70.3%↓`

File	Before (Size / Brotli)	After (Size / Brotli)
`dist/dev/packages/@ember/-internals/deprecations/index.js`	`5 kB` / `1.5 kB`	^-5.11%↓`4.7 kB` / ^-2.16%↓`1.5 kB`
`dist/ember-template-compiler.js`	`766.2 kB` / `113.9 kB`	—
`dist/ember-template-compiler.js.map`	`1.5 MB` / `259.8 kB`	—
`dist/ember-testing.js`	`12.5 kB` / `2.8 kB`	—
`dist/ember-testing.js.map`	`12.7 kB` / `3.3 kB`	—
`dist/ember.debug.js`	`2.1 MB` / `315.9 kB`	—
`dist/ember.debug.js.map`	`3.4 MB` / `626.1 kB`	—
`dist/ember.prod.js`	`1.9 MB` / `287.1 kB`	—
`dist/ember.prod.js.map`	`3.2 MB` / `599.4 kB`	—
`dist/prod/packages/@ember/-internals/deprecations/index.js`	`4.7 kB` / `1.4 kB`	^-5.47%↓`4.4 kB` / ^-2.49%↓`1.4 kB`
`lib/index.js`	`15.2 kB` / `2.7 kB`	^-25%↓`11.4 kB` / ^-36%↓`1.7 kB`
`types/stable/@ember/-internals/deprecations/index.d.ts`	`1.1 kB` / `297 B`	^-15.8%↓`941 B` / ^-9.43%↓`269 B`
`types/stable/ember-template-compiler/index.d.ts`	`224 B` / `107 B`	^-53.6%↓`104 B` / ^-22.4%↓`83 B`
`types/stable/loader/lib/index.d.ts`	`129 B` / `82 B`	—
`types/stable/require.d.ts`	`129 B` / `82 B`	—
Total _{(Includes all files)}	`18.3 MB` / `3.5 MB`	^-70.3%↓`5.4 MB` / ^-63.2%↓`1.3 MB`
Tarball size	`4 MB`	^-69.7%↓`1.2 MB`

_{🤖 This report was automatically generated by pkg-size-action}

NullVoxPopuli-ai-agent · 2026-03-29T04:14:21Z

Upstream PRs needed for v7 compatibility

The following ecosystem packages access absolutePaths.templateCompiler or paths from the ember-source addon, which are removed in v7. PRs have been opened to handle the missing properties gracefully:

Package	PR	Issue
ember-cli	ember-cli/ember-cli#10971	`paths.debug` in `_initVendorFiles`
@embroider/compat	embroider-build/embroider#2695 / embroider-build/embroider#2696	vendor file creation
ember-cli-htmlbars	ember-cli/ember-cli-htmlbars#793	`absolutePaths.templateCompiler` in `templateCompilerPath()`
ember-auto-import	embroider-build/ember-auto-import#708	`absolutePaths.templateCompiler` in `cleanBabelConfig()`

All four are patched via pnpm in #21262 (merged). Once the upstream PRs are released, the patches can be removed.

Additionally, #21265 improves those patches to use require.resolve('ember-source/ember-template-compiler/index.js') instead of hardcoded dist paths.

Add pnpm patches for ember-cli and @embroider/compat paths fix Patches ember-cli@6.11.0 (ember-cli/ember-cli#10971) and @embroider/compat@4.1.16 (embroider-build/embroider#2695) to handle ember-source no longer exporting `paths` in v7. - ember-cli: guard `_initVendorFiles` against missing `paths` - @embroider/compat: skip legacy vendor file creation when `paths` absent Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Add ember-cli-htmlbars patch, fix sourcemap test - Patch ember-cli-htmlbars@7.0.0 to handle missing absolutePaths in v7 ember-source, falling back to the ESM template compiler path. - Update sourcemap-test.js for v7's ESM-only dist structure (dist/ember.debug.js no longer exists). - Include template-compiler-test.js fix for ESM imports. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Fix ember-cli-htmlbars patch: use dist/dev/ path for v7 The v7 build outputs to dist/dev/packages/ and dist/prod/packages/, not dist/packages/. The template compiler fallback path must use the dev directory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Patch ember-auto-import to handle missing absolutePaths ember-auto-import also accesses emberSource.absolutePaths.templateCompiler for babel template compilation config. Add the same fallback to the dist/dev/ ESM template compiler path for v7. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Use require.resolve instead of hardcoded dist path in patches Replace hardcoded `dist/dev/packages/ember-template-compiler/index.js` with `require.resolve('ember-source/ember-template-compiler/index.js')` which resolves through the package exports map, making the patches resilient to dist layout changes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Remove pnpm patches for ember-cli-htmlbars, ember-auto-import, @embroider/compat These patches were temporary shims for v7 compatibility. The upstream PRs have landed: - ember-cli-htmlbars: ember-cli/ember-cli-htmlbars#793 - ember-auto-import: embroider-build/ember-auto-import#708 - @embroider/compat: embroider-build/embroider#2695 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Lockfile

lib/index.js

NullVoxPopuli force-pushed the nvp/v7-test branch from 2967f47 to 2d1f94f Compare March 24, 2026 21:29

NullVoxPopuli changed the title ~~Nvp/v7 test~~ v7 Mar 24, 2026

NullVoxPopuli-ai-agent mentioned this pull request Mar 25, 2026

Stop reading dist/ember-template-compiler.js from ember-source embroider-build/embroider#2691

Closed

NullVoxPopuli force-pushed the nvp/v7-test branch 6 times, most recently from 39221bc to eb0a25f Compare March 28, 2026 02:24

This was referenced Mar 28, 2026

Update template-compiler-test for v7 ESM-only build #21260

Merged

Update template-compiler-test for ESM-only build #21261

Merged

NullVoxPopuli force-pushed the nvp/v7-test branch 2 times, most recently from 95b7797 to 1e38422 Compare March 29, 2026 01:41

This was referenced Mar 29, 2026

Handle missing absolutePaths for ember-source v7+ ember-cli/ember-cli-htmlbars#793

Merged

Handle missing absolutePaths for ember-source v7+ embroider-build/ember-auto-import#708

Merged

NullVoxPopuli force-pushed the nvp/v7-test branch from 0b26c27 to 625fd39 Compare March 29, 2026 20:23

Bump version back to 7.0.0-alpha

524f6ee

NullVoxPopuli force-pushed the nvp/v7-test branch from 625fd39 to 317a1fc Compare March 29, 2026 20:50

NullVoxPopuli force-pushed the nvp/v7-test branch from 317a1fc to fc4ea40 Compare March 29, 2026 20:52

NullVoxPopuli marked this pull request as ready for review March 29, 2026 20:53

kategengler reviewed Mar 29, 2026

View reviewed changes

lib/index.js Outdated Show resolved Hide resolved

kategengler previously approved these changes Mar 29, 2026

View reviewed changes

Remove treeForVendor

965b155

NullVoxPopuli dismissed kategengler’s stale review via 965b155 March 29, 2026 21:03

Remove now unused dependencies

2914f4c

kategengler previously approved these changes Mar 29, 2026

View reviewed changes

Rename classicUseModules to classic

ca0d2f0

NullVoxPopuli dismissed kategengler’s stale review via ca0d2f0 March 29, 2026 22:39

kategengler approved these changes Mar 29, 2026

View reviewed changes

NullVoxPopuli merged commit 8352f23 into main Mar 29, 2026
38 checks passed

NullVoxPopuli deleted the nvp/v7-test branch March 29, 2026 23:43

This was referenced Mar 29, 2026

Bump version back to 7.0.0-alpha #21239

Closed

Remove ember cli htmlbars 6 support (classic builds now require use-ember-modules) #21137

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

v7#21240

v7#21240
NullVoxPopuli merged 5 commits intomainfrom
nvp/v7-test

NullVoxPopuli commented Mar 24, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 24, 2026 •

edited

Loading

Uh oh!

NullVoxPopuli-ai-agent commented Mar 29, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

NullVoxPopuli commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Package size report -70.3%↓

Uh oh!

NullVoxPopuli-ai-agent commented Mar 29, 2026

Upstream PRs needed for v7 compatibility

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NullVoxPopuli commented Mar 24, 2026 •

edited

Loading

github-actions bot commented Mar 24, 2026 •

edited

Loading

📊 Package size report `-70.3%↓`