Open
Conversation
0f3227f to
a9b39e7
Compare
aca914e to
22a0b83
Compare
13f401d to
0b99867
Compare
037c889 to
4e0e8a9
Compare
49c7f66 to
b58512d
Compare
aadcc2e to
d630092
Compare
bb4c5ab to
c1e57bd
Compare
NullVoxPopuli
requested changes
Mar 24, 2026
Contributor
There was a problem hiding this comment.
Need to:
-
review the overall changes before release:
-
review new rules and make sure none of them are in the recommended set (requires RFC to change recommended)
git diff v12.7.6-eslint-plugin-ember -- lib/config/ lib/config-legacy/ | wc -l # => 0 git diff v12.7.6-eslint-plugin-ember -- "lib/recommended*" # => only comma changes due to prettier
-
test on big app at work and see if it's mostly bugfixes being applied, nothing actually breaking for those up to date
any changes here could be considered bugfix, post-release
- review docs for new rules and assure that the hbs vs gjs docs are taken care of
- assign some of the new rules to hbs/loose mode only, if applicable
- assign some of the old rules as gjs/strict mode only, if applicable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a preview of the release that release-plan has prepared. To release you should just merge this PR 👍
Release (2026-04-04)
💥 Breaking Change
eslint-plugin-ember🚀 Enhancement
eslint-plugin-emberno-tracked-built-insrule and ember-source version utility (@Copilot)no-modifier-argument-destructuringrule (@Copilot)🐛 Bug Fix
eslint-plugin-emberno-test-import-exportfalse positive on non-test files ending in -test (@johanrd)template-block-indentation(@johanrd)template-attribute-indentation) (@johanrd)template-no-duplicate-landmark-elements) (@johanrd)template-deprecated-inline-view-helper) (@johanrd)template-no-curly-component-invocation) (@johanrd)template-no-duplicate-id) (@johanrd)template-no-action-modifiers(@johanrd)template-no-array-prototype-extensions(@johanrd)template-no-multiple-empty-lines(@johanrd)no-negated-condition(@johanrd)template-no-obscure-array-access(@johanrd)template-no-curly-component-invocation(@johanrd)template-attribute-order(@johanrd)avoid-leaking-state-in-ember-objectsfalse positives with TypeScript type assertions (@johanrd)import { service }in order-in-* rules andno-implicit-injections(@johanrd)findByexclusion inno-array-prototype-extensions(@johanrd)no-tracked-properties-from-argscrash on method calls (@johanrd)no-empty-glimmer-component-classesfalse positive ondeclare class(@johanrd)no-test-import-exportfalse positive on package imports (@johanrd)require-computed-macrosself-referential autofix (@johanrd)no-deprecated-router-transition-methodscrash with mixins (@johanrd)no-actions-hashcrash on TypeScript declare properties (@johanrd)no-computed-properties-in-native-classeswhen file mixes native and classic classes (@johanrd)template-no-autofocus-attribute) (@johanrd)template-no-action-modifiers) (@johanrd)template-no-nested-interactive) (@johanrd)template-no-invalid-aria-attributes) (@johanrd)template-no-invalid-role) (@johanrd)template-no-implicit-this) (@johanrd)template-no-link-to-positional-params) (@johanrd)template-link-href-attributes) (@johanrd)template-link-rel-noopener) (@johanrd)template-no-capital-arguments) (@johanrd)template-no-log) (@johanrd)template-no-element-event-actions) (@johanrd)template-no-action) (@johanrd)template-no-outlet-outside-routes) (@johanrd)template-no-inline-styles) (@johanrd)🏠 Internal
eslint-plugin-emberCommitters: 8