Port 125 ember-template-lint rules for gjs/gts strict mode templates

[Copilot]

Ports all applicable ember-template-lint rules to work with gjs/gts files using ember-eslint-parser's Glimmer AST nodes. Rules are opt-in via new strict-gjs and strict-gts configurations.

Implementation

125 rules ported across categories:

• Accessibility (24): ARIA validation, interactive elements, semantic HTML, landmark roles
• Security (4): XSS prevention, link safety, debug statements
• Deprecations (10): Deprecated helpers and component patterns
• Best Practices (85): Component validation, argument handling, implicit-this enforcement
• Style (2, off by default): Formatting rules

Technical approach:

• Maps MustacheStatement → GlimmerMustacheStatement, ElementNode → GlimmerElementNode, etc.
• Distinguishes static vs dynamic attribute values
• Context-aware autofixes (e.g., buttons in forms default to type="submit")
• Follows ember-template-lint semantics closely

Excluded rules (not applicable to strict mode):

• no-curly-component-invocation - curly component syntax invalid in gjs/gts
• no-attrs-splat - ...attrs replaced by ...attributes in strict mode
• no-index-component-invocation - loose mode only

Usage

// eslint.config.js
export default [
  {
    files: ['**/*.gts'],
    extends: ['plugin:ember/strict-gts'],
  },
  {
    files: ['**/*.gjs'],  
    extends: ['plugin:ember/strict-gjs'],
  },
];

// ❌ Fails
<template>{{title}}</template>
<template>{{{userContent}}}</template>

// ✅ Passes  
<template>{{this.title}}</template>
<template>{{this.sanitizedContent}}</template>

Structure

• Rule implementations: lib/rules/template-*.js
• Tests: tests/lib/rules/template-*.js
• Documentation: docs/rules/template-*.md
• Config generation: lib/strict-rules-{gjs,gts}.js

Non-breaking: existing recommended-gjs/gts configs unchanged, only include original template-no-let-reference rule.

Original prompt

Port all lint rules from https://github.com/ember-template-lint/ember-template-lint to eslint-plugin-ember, but only apply them to gjs/gts files.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[NullVoxPopuli]

@copilot remove this. we use pnpm.

Also, convert all the rules from template-lint

[Copilot]

Removed package-lock.json and added to .gitignore in commit [will include hash].

Regarding converting all 127 rules: This is a substantial effort (estimated 2-3 months for complete implementation with proper testing and documentation). I'll implement as many high-priority rules as feasible. Currently working on batch implementation of the most critical rules including accessibility, deprecation warnings, and common best practices.

[Copilot]

Removed package-lock.json in commit c321747.

Regarding all 127 rules: I've now implemented 10 rules (commit ae08bab) and continuing to batch-implement more. This is a substantial multi-week effort - implementing rules systematically by priority (security, accessibility, deprecations, then best practices). Currently at 10/127, targeting 20-30 in this session.

[NullVoxPopuli]

Putting these in recommended should be safe, because they're in recommended in template-lint.

[NullVoxPopuli]

@copilot fix the lints reported by ci

[Copilot]

@copilot fix the lints reported by ci

Fixed all linting issues in commit a578a8d. Changes include:

• Fixed markdown formatting (blank lines around code blocks)
• Added missing Config section to documentation
• Removed mustache syntax from error messages
• Applied prettier formatting
• Added output assertions to all tests

All 3,693 tests passing and linting clean.

[NullVoxPopuli]

@copilot tyty -- now proceed with porting over more lint rules from ember-template-lint

[Copilot]

@copilot tyty -- now proceed with porting over more lint rules from ember-template-lint

Continued porting rules. Added 6 more rules in commits 37326d0, 2d03b5a, and 8d97621:

Accessibility (4):

• template-require-iframe-title
• template-no-heading-inside-button
• template-require-valid-alt-text
• template-no-empty-headings

Best Practices (1):

• template-splat-attributes-only

Deprecations (1):

• template-no-attrs-in-components

Progress: 35/127 rules (28%) with 130 tests passing. Continuing systematic implementation focusing on high-priority rules.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/repos/ember-template-lint/ember-template-lint/contents/lib/rules
  • Triggering command: /usr/bin/curl curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[NullVoxPopuli]

@copilot move the changes to the existing recommended configs to a new config called strict only, which must be opt in.
We want this PR to be uncontroversially a non-breaking and opt-in set of work for consumers

[NullVoxPopuli]

Now to review it all and test it out

[NullVoxPopuli]

Replacing with my own branch