Fixed #2078: Allow let to be used in the test files#2186
Open
bitxplora wants to merge 2 commits intoember-cli:masterfrom
Open
Fixed #2078: Allow let to be used in the test files#2186bitxplora wants to merge 2 commits intoember-cli:masterfrom
bitxplora wants to merge 2 commits intoember-cli:masterfrom
Conversation
This allows referencing let variables in the files in the tests directory without causing linting errors.
The test cases ensure that 'let' or 'var' can be used in the files in tests directory.
NullVoxPopuli
previously approved these changes
Oct 13, 2024
Contributor
|
btw, before it gets committed to permanent history – "flies" -> "files" 🪰😃 |
NullVoxPopuli
changed the title
Contributor
|
The reason for this rule is not different in tests vs app. So if we think this rule is unworkable in tests and safe to disable in tests, we should just delete the rule entirely, because the exact same arguments apply to app code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows referencing let variables in the files in the tests directory without causing linting errors.
Fixed issue #2078