[INTERNAL] Move logic out of ember-cli commands#1063
Open
bertdeblock wants to merge 1 commit intoember-cli:mainfrom
Open
[INTERNAL] Move logic out of ember-cli commands#1063bertdeblock wants to merge 1 commit intoember-cli:mainfrom
ember-cli commands#1063bertdeblock wants to merge 1 commit intoember-cli:mainfrom
Conversation
4d77de0 to
bda3dce
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1063 +/- ##
==========================================
- Coverage 95.54% 95.15% -0.39%
==========================================
Files 21 18 -3
Lines 516 475 -41
==========================================
- Hits 493 452 -41
Misses 23 23 ☔ View full report in Codecov by Sentry. |
Member
|
what would it look like to invert this? i.e. make this a type=module package with an index.cjs ? I'm only asking because we're changing most files across to mjs and it seems like that is wanting to be type=module 🤔 |
Member
Author
|
I was under the assumption that importing cjs from inside a type=module package was not an option. But I assume this might work by configuring package.json#exports? Would be better indeed. |
Member
|
yes you can configure package.json exports to point at a cjs file for the index 👍 |
Member
Author
|
Alright, would be much better indeed. Will update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this, we can easily:
./lib/ember-cli-commands) to.mjs1.ember-trywithoutember-cli