Skip to content

Fix eos_crc32 signature mismatch and duplicate variable in recovery write path #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jayakrishnan9539 wants to merge 3 commits into from
Closed

Fix eos_crc32 signature mismatch and duplicate variable in recovery write path #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b847e2
fix: correct eos_crc32 signature mismatch and duplicate slot_size dec…
Aug 30, 2026
04aa4d9
test: verify commit signing works
Aug 30, 2026
f43aa1c
test: verify commit signing works v2
Jayakrishnan9539 Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions core/recovery.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,6 @@ static int recovery_handle_write(eos_slot_t slot, uint32_t offset, uint16_t len)
/* offset/len come straight from the wire; without this check a
* recovery client can write past the slot boundary into the other
* slot, boot-control blocks, or the boot log. */
uint32_t slot_size = eos_hal_slot_size(slot);
if (slot_size == 0 || (uint64_t)offset + len > (uint64_t)slot_size)
return recovery_send_nack();

Expand Down Expand Up @@ -514,4 +513,4 @@ int eos_recovery_enter(eos_bootctl_t *bctl)
}

return EOS_OK;
}
}
2 changes: 1 addition & 1 deletion include/eos_image.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ int eos_crc32_checked(uint32_t addr, size_t len, uint32_t *out_crc);
* @param len Length in bytes.
* @return CRC32 value, or 0 if the region could not be read.
*/
int eos_crc32(uint32_t addr, size_t len, uint32_t *out);
uint32_t eos_crc32(uint32_t addr, size_t len);

#ifdef __cplusplus
}
Expand Down