Skip to content

Fix Build#18

Closed
alexheifetz wants to merge 1 commit intomainfrom
fix-build
Closed

Fix Build#18
alexheifetz wants to merge 1 commit intomainfrom
fix-build

Conversation

@alexheifetz
Copy link
Contributor

This pull request updates test helper methods and test data setup to improve test isolation and accuracy, particularly by ensuring that test queries and data are clearly separated from production data. The changes also simplify some test double implementations.

Test query isolation:

  • Updated countComposers() and countWorks() in TestDataHelper.java to count only test data by adding a WHERE clause filtering on primarySource = 'test'. [1] [2]

Test data setup improvements:

  • Changed TEST_PERFORMANCE_ID in YouTubePerformancePersistenceIntegrationTest.java to use a prefix for clearer test identification.
  • Modified test data creation in YouTubePerformancePersistenceIntegrationTest.java to set primarySource using a parameter, and updated the data map accordingly for flexibility and clarity. [1] [2]

Test double simplification:

  • Removed unused or redundant methods from the FakeEmbeddingService and its model in TestLlmConfiguration.java to streamline the test implementation. [1] [2] [3]

@alexheifetz alexheifetz deleted the fix-build branch March 23, 2026 07:39
@alexheifetz alexheifetz restored the fix-build branch March 23, 2026 07:43
@alexheifetz alexheifetz deleted the fix-build branch March 23, 2026 07:44
@alexheifetz alexheifetz restored the fix-build branch March 23, 2026 07:44
@alexheifetz alexheifetz deleted the fix-build branch March 23, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant