Don't close the connection on a receive timeout#486
Open
keathley wants to merge 1 commit intoelixir-mint:mainfrom
Open
Don't close the connection on a receive timeout#486keathley wants to merge 1 commit intoelixir-mint:mainfrom
keathley wants to merge 1 commit intoelixir-mint:mainfrom
Conversation
Member
|
CI found a failing test for this. Is it clear from the API when Mint closes a connection on errors and when it doesn't or should we document this? |
Contributor
|
To Eric's comment I think yes we should. I feel it would be pretty confusing to not know that, and while I think not closing on timeouts is reasonable I also want to make sure we loudly document that. |
Author
|
@whatyouhide That makes sense to me. I should have time to fix tests and update docs later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its often useful to be able to test that a connection has no data waiting on it like
recv(socket, 0, 0). This PR handles the timeout error and returns it to the caller, rather than defaulting to closing the connection.