Check referenced target text in skip_undefined_reference_warnings_on#2224
Open
eksperimental wants to merge 1 commit intoelixir-lang:mainfrom
Open
Conversation
`skip_undefined_reference_warnings_on` only checked the source document (id, module, file) against the skip list - not the referenced path. So adding a target like "LICENSES/LICENSE.txt" to the list had no effect. Now the target path is also checked (with and without a fragment). Related issue: elixir-lang#2221
|
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/23415396270/artifacts/6050153718 |
eksperimental
changed the title
skip_undefined_reference_warnings_on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skip_undefined_reference_warnings_ononly checked the source document (id, module, file) against the skip list - not the referenced path.So adding a target like "LICENSES/LICENSE.txt" to the list had no effect. Now the target path is also checked (with and without a fragment).
Related issue: #2221