feat(ui): register bash, java, and pkl Prism grammars for CodeBlock - #8
Merged
Conversation
baasil (baasilali)
added
the
documentation
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 97.89% 97.98% +0.08%
==========================================
Files 38 39 +1
Lines 712 743 +31
Branches 318 310 -8
==========================================
+ Hits 697 728 +31
Misses 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds additional Prism language grammars to the UI package so CodeBlock can syntax-highlight bash, java, and a custom pkl grammar using the Prism instance shipped with prism-react-renderer.
Changes:
- Add a side-effect module that registers
bash,java, andpklgrammars intoPrism.languages. - Ensure
CodeBlockloads these grammars by importing the registration module. - Update package
sideEffectsconfiguration intended to prevent tree-shaking of the registration module.
File summaries
| File | Description |
|---|---|
| packages/ui/src/components/prism-languages.ts | Adds Prism grammar registrations for bash, java, and a custom pkl grammar. |
| packages/ui/src/components/code-block.tsx | Imports the grammar registration module so CodeBlock can highlight the new languages. |
| packages/ui/package.json | Updates sideEffects to try to preserve the side-effectful grammar registration module during bundling. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.