ci(catbox): enable goss/web smoke tests at container-build time#694
Open
funkypenguin wants to merge 1 commit into
Open
ci(catbox): enable goss/web smoke tests at container-build time#694funkypenguin wants to merge 1 commit into
funkypenguin wants to merge 1 commit into
Conversation
catbox's metadata.json had tests.enabled=false, which meant the
build pipeline shipped images without verifying the binary even
starts. That gap let 0.65.0 land with an unbalanced
{{if}}/{{end}} in backfill.html — go build + tests passed, the
image was published, and the binary panicked the moment a
tenant tried to run it ("template: backfill.html:167:
unexpected EOF").
Flipping to enabled=true exercises the goss.yaml smoke test in
the private repo (process: catbox running + GET /health 200 +
GET /ui/settings 200). The Dockerfile change to create /config
owned by the elfie user lives in the private repo PR alongside.
Closes the gap for the startup-class failures; in-Go template
parse regressions are also now caught by TestTemplatesParse in
the catbox repo (PR 315).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired with elfhosted/containers-private#19 that adds the /config mkdir to the Dockerfile and brings goss.yaml up to date. Both need to land before the next catbox release.
Why
0.65.0 catbox shipped with an unbalanced `{{if}}/{{end}}` in backfill.html, which crashed startup with `template: backfill.html:167: unexpected EOF`. `go build` + tests passed, the image was published, the binary panicked the moment a tenant tried to run it.
With `tests.enabled=false` on catbox, the container build pipeline had nothing checking the binary even starts.
Change
Flip `tests.enabled` to true so the dgoss smoke test runs against the just-built image. The actual check (process + /health + /ui/settings) lives in the goss.yaml in containers-private.
Test plan