App: cache menu model, wait to init pinned action#680
Open
danirabbit wants to merge 4 commits intomasterfrom
Open
App: cache menu model, wait to init pinned action#680danirabbit wants to merge 4 commits intomasterfrom
danirabbit wants to merge 4 commits intomasterfrom
Conversation
Merged
Contributor
|
I don't think this PR addresses the bug outlined in elementary/dock#520 (comment). In an effort to triple check that my local build was working correct, I made a local change to App.vala on my machine. To do this I did the following:
My goal was to make 100% sure that the build I was using, indeed had your patches in there....which it did. I then went ahead and ran my tests in elementary/dock#520 (comment) Anyways, this is a screenshot of what I would see when I used this patched app.vala with my own change to the context menu item.
[App.vala.txt](https://github.com/user-attachments/files/23691851/App.vala.txt)
I renamed app.vala to app.vala.txt so the upload to github would work. But yea, it's the same file minus line 251.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


There's likely a race here that makes the applications menu unpin items if the dock isn't loaded yet