fix: use testName/testSubType filters instead of hidden testCategory column - #2307
Conversation
|
👋 @sravankumarkunadi |
📝 WalkthroughWalkthroughThe dashboard filter-construction helper now omits ChangesDashboard filter correction
Estimated code review effort: 2 (Simple) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This is a patch to the bundled index.html no source-level tests or docs apply here since the UI is built separately. Happy to add anything if needed though! |
Description
Fixes #2294
Clicking a test category tile on the Dashboard (e.g. "Anomalies", "Volume") navigates to the Test Results tab with a
testCategoryfilter applied. However,testCategoryis a hidden column that is never populated from row data, so the filter matches no rows and the tab appears empty.This removes the
testCategoryshortcut fromY0nand falls back to the existingtestName/testSubTypefilter logic, which correctly matches the data in the Test Results table.Note on the changed file
The only changed file is
elementary/monitor/data_monitoring/report/index.html, which is the built report bundle, so the diff is a one-token change in minified code. That means the next UI build will regenerate it and drop this fix unless the same change also lands in the UI source. Happy to open that PR too if you point me at the right repo — otherwise treat this as the stopgap for the shipped report.Summary by CodeRabbit