Repository navigation
build(deps-dev): bump @electron-forge/shared-types from 8.0.0-alpha.10 to 8.0.1 #2069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/npm_and_yarn/electron-forge/shared-types-8.0.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+155
−14
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 CI and release jobs that run
yarn install --immutablewill probably fail after this merge, because the lockfile no longer agrees with the root resolution. The rootresolutionsin package.json:34 still pins@ electron-forge/shared-typesto8.0.0-alpha.10. Yarn rewrites every shared-types descriptor to that version, but the new yarn.lock has only an@ npm:8.0.1entry. Even a non-immutable install would put alpha.10 back, so the bump changes nothing. Fix: make the root resolution and the app pin agree, then regenerate yarn.lock withflock /tmp/fiddle-2027-yarn.lock yarn install. Either bump the resolution to8.0.1together with the bump, or close this PR.Why this was flagged
The root package.json:33-34
resolutionsforces@ electron-forge/shared-typesto8.0.0-alpha.10(alongside@ electron-forge/maker-base). On the base branch the lockfile honours this. yarn.lock:567 holds@ electron-forge/shared-types@ npm:8.0.0-alpha.10, and maker-base also stays at alpha.10 even though maker-squirrel asks fornpm:8.0.1. This diff replaces that entry with@ electron-forge/shared-types@ npm:8.0.1and adds@ electron-forge/tracer@ npm:8.0.1and the listr2 11 tree. It leaves the resolution unchanged, so most Forge packages still referencenpm:8.0.0-alpha.10(yarn.lock:359, 377, 409 and others) with no lockfile entry to resolve to..github/workflows/ci.yml:56and:138, andrelease.yml:57,:127and:220, runyarn install --immutable. Yarn re-resolves through the resolution to alpha.10, needs to change the lockfile, and so fails the install, which the base branch does not. Running a plain install instead puts the alpha.10 entry back, so the 8.0.1 bump never takes effect.Verification: normal. This happens on every CI or release run of
yarn install --immutableafter the merge. Root package.json:34 is untouched by the diff and still pins@ electron-forge/shared-typesto8.0.0-alpha.10, but the diff replaces yarn.lock line 567 with"@ electron-forge/shared-types@ npm:8.0.1", so there is no longer any shared-types alpha.10 key. So an immutable install sees that the lockfile would change and fails.