Repository navigation
build(deps): bump @sentry/electron from 7.18.0 to 8.3.0 - #2048
dependabot[bot] wants to merge 5 commits into
Conversation
dependabot
Bot
added
dependencies
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. It's a major-version bump of @ sentry/electron (7 to 8, with Sentry JS going from 10 to 11) and no source changes, so it would still be worth having a person confirm the app's Sentry setup works on the new major.
What was reviewed:
- The package.json bump and the regenerated yarn.lock. The new @ sentry/* entries are 11.8.0, and @ sentry/bundler-plugins adds oxc-parser native bindings, the
sentryCLI, dotenv and glob as transitive dependencies. - The Sentry API the app uses.
packages/app/src/main/crash/sentry.tscallsIPCMode.Classic,defaultIntegrations: falseand an explicit list of 14 integrations. The preload importshookupIpcfrom@ sentry/electron/preload-namespaced, and the About page imports@ sentry/electron/renderer. I couldn't check offline whether these still exist in v8 and behave the same way.
Extended reasoning...
The change bumps @ sentry/electron in packages/app/package.json across a major version and regenerates about 550 lines of yarn.lock, with no source changes. It touches crash reporting, which is a data-exposure surface. The app sets a privacy-focused integration allowlist, a scrubbing beforeSend hook and classic preload IPC, and all of these depend on v8 keeping the same exports and defaults. That compatibility can't be confirmed from the diff, and the lockfile also adds a sizable new transitive dependency tree (bundler-plugins, oxc-parser native binaries, the sentry CLI). Because this is a major bump of a runtime dependency on a privacy-sensitive path, a human look is warranted, not an automatic approval.
fb906d4 to
fc926c2
Compare
Bumps [@sentry/electron](https://github.com/getsentry/sentry-electron) from 7.18.0 to 8.3.0. - [Release notes](https://github.com/getsentry/sentry-electron/releases) - [Changelog](https://github.com/getsentry/sentry-electron/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-electron@7.18.0...8.3.0) --- updated-dependencies: - dependency-name: "@sentry/electron" dependency-version: 8.3.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
fc926c2 to
f4e3537
Compare
@sentry/core 11 removed `sendDefaultPii`. Without `dataCollection`, v11 defaults collect everything, including user info (IP inference), so set `dataCollection` explicitly in the main and renderer inits to keep what `sendDefaultPii: false` turned off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WZZBjALv9aNBfSEuHb4yEu
There was a problem hiding this comment.
I reviewed the latest push, including the new dataCollection migration commit, and didn't find any bugs. It landed after the existing human approval and changes privacy settings for crash reporting in a major SDK upgrade, so a maintainer should look at it again.
What was reviewed:
sentry.tsandabout/index.tsx:sendDefaultPii: falseis replaced by the samedataCollectionobject in both places. Every category is turned off, anddefaultIntegrations: false, the integrations allowlist andipcMode: Classicare unchanged.sentry.test.ts: the assertion now checksuserInfo: falseandhttpBodies: []underdataCollection.yarn.lock: @ sentry/* moves from 10.73.0 to 11.8.0. @ sentry/node 11.8.0 now pulls@ sentry/bundler-plugins, which brings inoxc-parser,dotenvand an unscopedsentryCLI package as runtime dependencies of the app. The@ opentelemetry/instrumentation,import-in-the-middleandrequire-in-the-middlepackages are gone.- I couldn't check the v8 option types here because
node_modulesisn't installed. Typecheck in CI is the real test of the new keys.
Extended reasoning...
The change bumps @ sentry/electron from 7.18.0 to 8.3.0, a major version. It replaces sendDefaultPii with an explicit dataCollection block in the main and renderer Sentry init, and updates one test. The surface it touches is data exposure: the settings that control what personal data crash reports send. The privacy migration commit was pushed after the only human approval. The lockfile adds new transitive runtime packages (bundler plugins, oxc-parser, dotenv, an unscoped sentry CLI) that a maintainer should be aware of. CODEOWNERS covers every path in this repo.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WZZBjALv9aNBfSEuHb4yEu
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WZZBjALv9aNBfSEuHb4yEu
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WZZBjALv9aNBfSEuHb4yEu
Bumps @sentry/electron from 7.18.0 to 8.3.0.
Release notes
Sourced from @sentry/electron's releases.
... (truncated)
Changelog
Sourced from @sentry/electron's changelog.
... (truncated)
Commits
cdf9ddbrelease: 8.3.0baf5f46fix: Stop renderer ANR watchdogs leaking and re-map protocol renderers after ...76ed986fix: Stop re-running event processors on every main process scope change (#1468)9349e15fix: Allow removal ofmessagelisteners on utility processes (#1472)d44fd5bfix: Only add main process context lines to renderer frames in the app direct...ef0a2fdfeat: Update JavaScript SDKs to v11.8.0 (#1471)8c552c4Merge commit 'f7263313afee6477872f5c46e685fd442c064018'6ddcc9eci: Remove previous auto SDK updates (#1465)f726331release: 8.2.0d48842cfeat: Update JavaScript SDKs to v11.7.0 (#1464)