Fix for user resizable transparent windows on win32 #49428
+1
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Here is my test matrix to gauge user impact... commonOptions = {
width: 800,
height: 600,
maxWidth: 1000,
minWidth: 400,
}
|
Author
|
Hi @zoy-l, Here is the PR for the win32 resize regression. I kept the changes as minimal as possible and attempted to keep behavior identical to docs/pre-39. |
Contributor
|
@mayfield Hey, I'm not an API reviewer, so I can't really give any suggestions. Please be patient — someone will review it. |
steveseguin
added a commit
to steveseguin/electron
that referenced
this pull request
Jan 22, 2026
This commit addresses the transparent window rendering issues on Windows: 1. Apply PR electron#49428 fix for CanResize() and IsResizable() - Frameless windows use hit-test based resize, not WS_THICKFRAME - CanResize() now returns resizable_ for frameless windows - IsResizable() simplified to delegate to CanResize() 2. Add SetIsTranslucent(false) for transparent windows after widget init - During widget creation, transparent windows get is_translucent_=true - This causes Win11 background material patch to call DefWindowProc(-1) - On some hardware, this causes black/grey backgrounds on focus events - Explicitly setting is_translucent_=false prevents this issue 3. Keep SetBackgroundMaterial() early return for transparent windows - Background materials (Mica/Acrylic) are not appropriate for transparent windows Fixes: electron#48554 See: electron#49428 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #48554
Description of Change
Frameless windows use hit-test based resize in chromium. Version 39 of electron regressed resizable windows that did not have a "frame" on win32.
Checklist
npm testpassesI ran tests but there were 245 fails that seemed to have nothing to do with my change. I don't know if HEAD is broken or if my windows VM is not setup correctly.
Release Notes
notes: Fix user resizing of transparent windows on win32 platform