Skip to content

backend: add pg_bigm for CJK full text search #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
exoego wants to merge 1 commit into
base: REL_18_3-pglite
Choose a base branch
from
+12 −1
Open

backend: add pg_bigm for CJK full text search #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,6 @@
[submodule "pglite/other_extensions/pgmq"]
path = pglite/other_extensions/pgmq
url = https://github.com/pgmq/pgmq
[submodule "pglite/other_extensions/pg_bigm"]
path = pglite/other_extensions/pg_bigm
url = https://github.com/pgbigm/pg_bigm.git
9 changes: 8 additions & 1 deletion pglite/other_extensions/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,14 @@ SUBDIRS = \
pg_uuidv7 \
pg_hashids \
pg_textsearch \
pgmq/pgmq-extension
pgmq/pgmq-extension \
pg_bigm

# Every other extension here includes PGXS unconditionally. pg_bigm gates it
# behind USE_PGXS and otherwise assumes it sits in the postgres tree as
# contrib/pg_bigm, which resolves contrib-global.mk to a path that does not
# exist from here. Set the flag for its build and its packaging step only.
all-pg_bigm-recurse pg_bigm.tar.gz: export USE_PGXS = 1

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Export USE_PGXS for every pg_bigm recursive target

When make -C pglite/other_extensions clean, distclean, install, or another standard recursive target is run, $(recurse) still enters pg_bigm, but this target-specific export applies only to all and the packaging target. Those sub-makes therefore take pg_bigm's in-tree branch and try to include the nonexistent contrib/pg_bigm build files described immediately above, causing otherwise supported Makefile targets to fail. Apply the export to all pg_bigm recursive targets (or arrange for the flag to be set inside the submodule invocation generally).

Useful? React with 👍 / 👎.


prefix ?= /pglite
EXTENSIONS_BUILD_ROOT := /tmp/extensions/build
Expand Down
1 change: 1 addition & 0 deletions pglite/other_extensions/pg_bigm
Open in desktop
Submodule pg_bigm added at 16034b