fix(ci): move canary npm publish into changesets workflow for OIDC auth#4216
Open
fix(ci): move canary npm publish into changesets workflow for OIDC auth#4216
Conversation
npm trusted publishing is configured per-package with a specific workflow filename. The packages trust changesets_release.yml, so the separate canary_npm_publish.yml could never authenticate via OIDC. Move canary publishing into the changesets workflow as a new job that runs when changesets didn't publish a release and agents packages changed. Delete the standalone canary workflow. Also add workflow_dispatch for manual testing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
balegas
force-pushed
the
fix/canary-npm-oidc-auth
branch
from
a8589a4 to
700e5b1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4216 +/- ##
==========================================
+ Coverage 61.54% 64.69% +3.15%
==========================================
Files 129 143 +14
Lines 17152 18979 +1827
Branches 4145 4615 +470
==========================================
+ Hits 10556 12279 +1723
- Misses 6594 6697 +103
- Partials 2 3 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
canary_npm_publish.yml— it can never authenticate via OIDCpublish-canaryjob tochangesets_release.yml(the workflow file trusted by npmjs.com)workflow_dispatchtrigger for manual testingContext
npm trusted publishing is configured per-package with a specific workflow filename. The
@electric-ax/*packages trustchangesets_release.yml, so any other workflow getsENEEDAUTH. Moving canary publishing into the same workflow file lets it share the OIDC trust relationship.The canary job:
<version>-canary.<sha>with--tag canary(won't affect stable installs)Test plan
🤖 Generated with Claude Code