-
Notifications
You must be signed in to change notification settings - Fork 296
Support OR with subqueries using DNF #3681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
robacourt
wants to merge
7
commits into
main
Choose a base branch
from
mob/support-or-in-subqueries-with-dnf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
❌ 28 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This comment has been minimized.
This comment has been minimized.
Contributor
|
Found 75 test failures on Blacksmith runners: Failures
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We already support tagged move-ins/outs for shapes with a single subquery dependency. Allowing multiple same-level subqueries currently results in 409/must-refetch on move-ins/outs because:
Desired behavior
Proposed approach (Option 1): multi-tags + client-side tag tracking + INSERT-as-UPSERT
Key idea
Treat each OR branch (or dependency) as an independent “reason” a row is in the shape:
This avoids 409/must-refetch and correctly handles overlap.
MVP scope (initial)**
✅ Support: multiple same-level subquery membership checks connected by OR:
🚫 Out of scope (initially):
Implementation plan (high-level tasks)
A) Server (sync-service)
B) Internal client in sync-service: Materializer
C) External clients (TypeScript at minimum)
D) Tests
Acceptance criteria